[EventDispatcher] TraceableEventDispatcher resets event listener priorities #17459
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
c960657
commented
Jan 20, 2016
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #15550 |
| License | MIT |
| Doc PR | - |
11d264c to
683169b
Compare
| $tdispatcher->addListener('foo', $listener1 = function () use (&$called) { $called[] = 'foo1'; }); | ||
| $tdispatcher->addListener('foo', $listener2 = function () use (&$called) { $called[] = 'foo2'; }); | ||
| $tdispatcher->addListener('foo', $listener1 = function () use (&$called) { $called[] = 'foo1'; }, 10); | ||
| $tdispatcher->addListener('foo', $listener2 = function () use (&$called) { $called[] = 'foo2'; }, 20); |
There was a problem hiding this comment.
the $listener1 and $listener2 variables are actually unused
|
@c960657 what is the lower Symfony version where this patch can be applied ? The bug seems to impact 2.7+ |
683169b to
fc40005
Compare
|
@stof The patch applies cleanly to 2.7+. The bug seems to have always been there, even back in 2.3 when TraceableEventDispatcher belonged to HttpKernel. |
fc40005 to
9d553b7
Compare
|
@c960657 If the bug is present in 2.3, we need to fix it there first. Can you work on creating a PR for 2.3? |
This was referenced Jan 21, 2016
|
@c960657 Sorry for that but I've closed the other PRs as the listener priority is only available as of 2.8, so I'm going to merge this one on 2.8. |
|
Thank you @c960657. |
fabpot
added a commit
that referenced
this pull request
Jan 25, 2016
…stener priorities (c960657) This PR was submitted for the master branch but it was merged into the 2.8 branch instead (closes #17459). Discussion ---------- [EventDispatcher] TraceableEventDispatcher resets event listener priorities | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #15550 | License | MIT | Doc PR | - Commits ------- 233e5b8 [EventDispatcher] TraceableEventDispatcher resets listener priorities
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.