[Form] make tests compatible with Symfony 2.8 and 3.0 #17463
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
xabbuh
commented
Jan 20, 2016
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | |
| License | MIT |
| Doc PR |
d1d2a89 to
4d2930e
Compare
|
@xabbuh Thank you!! (you were faster than me with this PR) :) It was my mistake. The test I created here: #17406 was only compatible with 2.7, but was merged to 2.8 and 3.0 too. Next time I have to check test in newer versions also. Sorry for that! (Also interesting, that the AppVeyor build was successful when there was a failing test. I create an issue for that.) 👍 Status: Reviewed |
|
@paradajozsef There was nothing wrong with your pull request. Referencing form types by their qualified class names does only work since Symfony 2.8 so we exactly had to do what you did in your PR. :) |
|
@xabbuh I see. Thanks for the reply! :) |
|
Thank you @xabbuh. |
fabpot
added a commit
that referenced
this pull request
Jan 21, 2016
…buh) This PR was merged into the 2.8 branch. Discussion ---------- [Form] make tests compatible with Symfony 2.8 and 3.0 | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | Commits ------- 4d2930e make tests compatible with Symfony 2.8 and 3.0
fabpot
added a commit
that referenced
this pull request
Jan 21, 2016
This PR was merged into the 3.1-dev branch. Discussion ---------- [Form] Make tests compatible with master | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - I wrote tests in this PR: #17406 which was compatible only with 2.7. @xabbuh fixed it in 2.8 and 3.0 here: #17463. And this PR fixes deprecated notices in master. Kind of an unfortunate situation... Commits ------- 96e40b2 Fix unit tests in master
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.