[Asset] CLI: use request context to generate absolute URLs #17503
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
xabbuh
commented
Jan 23, 2016
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #15448 |
| License | MIT |
| Doc PR |
| @@ -12,7 +12,7 @@ | |||
| namespace Symfony\Bridge\Twig\Extension; | |||
|
|
|||
| use Symfony\Component\HttpFoundation\RequestStack; | |||
| use Symfony\Component\HttpFoundation\Request; | |||
There was a problem hiding this comment.
This should be kept (there is a reference in a @see annotation)
There was a problem hiding this comment.
Good catch, PhpStorm doesn't seem to handle that properly. I changed the annotation to use the FQCN instead. Okay for you?
There was a problem hiding this comment.
No, we are using short class names everywhere else.
There was a problem hiding this comment.
okay, I reverted this one
|
👍 |
e72f7d0 to
766a648
Compare
|
@xabbuh a very nice solution for a very demanded feature. Thanks! |
|
Thank you @xabbuh. |
fabpot
added a commit
that referenced
this pull request
Jan 23, 2016
… (xabbuh) This PR was merged into the 2.7 branch. Discussion ---------- [Asset] CLI: use request context to generate absolute URLs | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #15448 | License | MIT | Doc PR | Commits ------- 766a648 CLI: use request context to generate absolute URLs
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.