[Form] ArrayChoiceList can now deal with a null in choices #17511
+8
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
Thank you @issei-m. |
fabpot
added a commit
that referenced
this pull request
Jan 27, 2016
… (issei-m) This PR was merged into the 2.7 branch. Discussion ---------- [Form] ArrayChoiceList can now deal with a null in choices re-create for mistaken #17502 --- | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Documentation says, since 2.7, choice value is treated as corresponding item value (if `choices_as_values` option is true). Null as well. ```php $builder->add('attending', 'choice', array( 'choices' => array( 'yes' => true, 'no' => false, 'maybe' => null, ), 'choices_as_values' => true, )); ``` But actually null doesn't work as expected since `ArrayChoiceList::getChoicesForValues()` uses `isset` to check whether given value exists in its choices. It should use `array_key_exists` instead to do so here. Commits ------- 68292bb [Form] ArrayChoiceList can now deal with a null in choices
Merged
fabpot
added a commit
that referenced
this pull request
Feb 18, 2016
This PR was merged into the 2.7 branch. Discussion ---------- [Form] add test for ArrayChoiceList handling null | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - I found this bug but then realised that it was already fixed in #17511. So this just adds a test. Commits ------- 00e3819 [Form] add test for ArrayChoiceList handling null
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
re-create for mistaken #17502
Documentation says, since 2.7, choice value is treated as corresponding item value (if
choices_as_valuesoption is true). Null as well.But actually null doesn't work as expected since
ArrayChoiceList::getChoicesForValues()usesissetto check whether given value exists in its choices.It should use
array_key_existsinstead to do so here.