ChoiceFormField of type "select" could be "disabled" #17542
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi, A select could be "globaly" disabled not only one of its options. http://www.w3schools.com/tags/att_select_disabled.asp
Check if field attribute disabled is working
| @@ -59,6 +59,10 @@ public function hasValue() | |||
| */ | |||
| public function isDisabled() | |||
| { | |||
| if (parent::isDisabled() && 'radio' !== $this->type) { | |||
There was a problem hiding this comment.
should be 'select' === $this->type (the test won't work for radio inputs)
|
Status: Needs work |
|
👍 LGTM ping @jakzal Status: Reviewed |
|
Thank you @bouland. |
fabpot
added a commit
that referenced
this pull request
Feb 26, 2016
…and) This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes #17542). Discussion ---------- ChoiceFormField of type "select" could be "disabled" Hi, New PR to add tests from the closed PR #15952 | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | Commits ------- 576c4b9 ChoiceFormField of type "select" could be "disabled"
This was referenced Feb 28, 2016
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
New PR to add tests from the closed PR #15952