[WebProfilerBundle] Don't inherit CSS text-transform property for the toolbar. #17544
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4a91c0b to
7a33800
Compare
|
Thank you @adamelso. |
fabpot
added a commit
that referenced
this pull request
Jan 27, 2016
…perty for the toolbar. (adamelso) This PR was submitted for the master branch but it was merged into the 2.8 branch instead (closes #17544). Discussion ---------- [WebProfilerBundle] Don't inherit CSS text-transform property for the toolbar. | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | When the `body` element has the CSS rule `text-transform: uppercase`, this is also applied to the toolbar. We could add a style to prevent that from happening but would mean the CSS is now writing rules for a framework's dev tools. Given the information in the toolbar may be case-sensitive, best thing to prevent text transformations by explicitly declaring `text-transform: none`.  Commits ------- fce0af0 [WebProfilerBundle] Don't inherit CSS text-transform property for the toolbar.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the
bodyelement has the CSS ruletext-transform: uppercase, this is also applied to the toolbar.We could add a style to prevent that from happening but would mean the CSS is now writing rules for a framework's dev tools.
Given the information in the toolbar may be case-sensitive, best thing to prevent text transformations by explicitly declaring
text-transform: none.