Skip to content

[Validator] PSR-6 cache: Avoid name collision #17550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 27, 2016
Merged

[Validator] PSR-6 cache: Avoid name collision #17550

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Symfony/Component/Validator/Mapping/Cache/Psr6Cache.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,14 +67,14 @@ public function write(ClassMetadata $metadata)
}

/**
* Replaces backslashes by underscores in a class name.
* Replaces backslashes by dots in a class name.
*
* @param string $class
*
* @return string
*/
private function escapeClassName($class)
{
return strtr($class, '\\', '_');
return strtr($class, '\\', '.');
}
}
9 changes: 9 additions & 0 deletions src/Symfony/Component/Validator/Tests/Mapping/Cache/Psr6CacheTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

use Symfony\Component\Cache\Adapter\ArrayAdapter;
use Symfony\Component\Validator\Mapping\Cache\Psr6Cache;
use Symfony\Component\Validator\Mapping\ClassMetadata;

/**
* @author Kévin Dunglas <dunglas@gmail.com>
Expand All @@ -14,4 +15,12 @@ protected function setUp()
{
$this->cache = new Psr6Cache(new ArrayAdapter());
}

public function testNameCollision()
{
$metadata = new ClassMetadata('Foo\\Bar');

$this->cache->write($metadata);
$this->assertFalse($this->cache->has('Foo_Bar'));
}
}