Skip to content

Conversation

Mx-Glitter
Copy link
Contributor

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR

@javiereguiluz
Copy link
Member

@Triiistan thanks for this fix. However, in addition to removing the wrong value, I'd like to replace it by the right property/value:

word-break: break-all;

Thanks!

@Mx-Glitter
Copy link
Contributor Author

@javiereguiluz I've tested it and here are my results:

  • Without word-break: break-all; (current situation)
    without break-all
  • With word-break: break-all;
    with break-all

I feel like cutting inside words removes readability, what do you think?

@javiereguiluz
Copy link
Member

@Triiistan the screenshots show an edge-case (the second line of the second log contains just a letter and it's weird). But in most cases, you see big gaps (like the second line of your first screenshot) because class namespaces are very long and browsers don't want to break them.

But honestly I don't have strong opinions for either side. The both have pros and cons.

@Mx-Glitter
Copy link
Contributor Author

Where it really changes things for example is on SQL query logs for example which can often spans on multiple lines. Cutting between words looks difficult to read IMHO, but I'm ok for doing that change if you don't feel the same way 😃

@fabpot
Copy link
Member

fabpot commented Jan 27, 2016

Thank you @Triiistan.

@fabpot fabpot merged commit 03d3182 into symfony:2.3 Jan 27, 2016
fabpot added a commit that referenced this pull request Jan 27, 2016
This PR was merged into the 2.3 branch.

Discussion
----------

Remove invalid CSS white-space value

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

Commits
-------

03d3182 Remove invalid CSS white-space value
@Mx-Glitter Mx-Glitter deleted the remove-invalid-css branch March 6, 2016 18:29
ostrolucky pushed a commit to ostrolucky/symfony that referenced this pull request Mar 25, 2018
This PR was merged into the 2.3 branch.

Discussion
----------

Remove invalid CSS white-space value

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

Commits
-------

03d3182 Remove invalid CSS white-space value
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants