[DependencyInjection] simplify the BC layer #17565
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The change to the `setFactoryService()` method is consistent with what we did with the `getFactoryService()` before (and how we handle the deprecation of strict references in Symfony 2.8).
|
Thank you @xabbuh. |
fabpot
added a commit
that referenced
this pull request
Jan 27, 2016
This PR was merged into the 2.7 branch. Discussion ---------- [DependencyInjection] simplify the BC layer | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | The change to the `setFactoryService()` method is consistent with what we did with the `getFactoryService()` before (and how we handle the deprecation of strict references in Symfony 2.8). Commits ------- 6cd5ee3 [DependencyInjection] simplify the BC layer
| @@ -99,7 +99,7 @@ public function setFactoryMethod($method) | |||
| /** | |||
| * {@inheritdoc} | |||
| */ | |||
| public function setFactoryService($service) | |||
| public function setFactoryService($service, $triggerDeprecationError = true) | |||
| { | |||
| $this->changes['factory_service'] = true; | |||
|
|
|||
There was a problem hiding this comment.
didn't you forget to spread the new argument to the parent ?
There was a problem hiding this comment.
Oh good catch, we never call this internally so this went unnoticed. Would you like to send a fix?
fabpot
added a commit
that referenced
this pull request
Jan 30, 2016
…parent class (xabbuh) This PR was merged into the 2.7 branch. Discussion ---------- [DependencyInjection] pass triggerDeprecationError arg to parent class | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #17565 (comment) | License | MIT | Doc PR | Commits ------- 350625d pass triggerDeprecationError arg to parent class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change to the
setFactoryService()method is consistent with whatwe did with the
getFactoryService()before (and how we handle thedeprecation of strict references in Symfony 2.8).