Support "!!binary" syntax (decodes base64 string) #17599
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only supported in folded-scalar (lines ending with | or >) form, or inline form. Example Yaml: items - name: !!binary "SGVsbG8sIHdvcmxkLg==" desc: !!binary | SGVsbG8sIH dvcmxkLg==
|
ping @xabbuh |
| @@ -21,6 +21,7 @@ | |||
| */ | |||
| class Inline | |||
| { | |||
| const REGEX_TAG_PATTERN = '((?P<tag>![\w!.\/:-]+) +)?'; | |||
There was a problem hiding this comment.
This should be moved to the Parser class.
|
Status: Needs work |
|
What about dumping ? Should we detect binary strings and dump them this way too ? |
|
Hi all, feel free to edit and merge the changes on your own name. Thank you. :-) |
|
@xabbuh Can you take over this PR? |
|
Will do. |
|
Thanks, closing this one then as there is a related linked issue. |
fabpot
added a commit
that referenced
this pull request
Feb 28, 2016
This PR was merged into the 3.1-dev branch. Discussion ---------- [Yaml] add support for parsing the !!binary tag | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #8094, #15587, #17599 | License | MIT | Doc PR | TODO Commits ------- 79a63d5 [Yaml] add support for the !!binary tag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only supported in folded-scalar (lines ending with | or >) form, or inline form.
Example Yaml:
items
name: !!binary "SGVsbG8sIHdvcmxkLg=="
desc: !!binary |
SGVsbG8sIH
dvcmxkLg==