[WebProfiler] Fixed logo and menu profiler for Microsoft Edge #17613
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WhiteEagle88
commented
Jan 30, 2016
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #16887 |
| License | MIT |
| Doc PR | - |
| @@ -1,4 +1,4 @@ | |||
| <svg version="1.1" xmlns="http://www.w3.org/2000/svg" x="0px" y="0px" height="24" viewBox="0 0 24 24" enable-background="new 0 0 24 24" xml:space="preserve"> | |||
| <svg version="1.1" xmlns="http://www.w3.org/2000/svg" x="0px" y="0px" width="40" height="24" viewBox="0 0 24 24" enable-background="new 0 0 24 24" xml:space="preserve"> | |||
There was a problem hiding this comment.
Shouldn't it be 24 as well here?
|
@fabpot, No. If you inspect logo in chrome, you can see 40x40. Maybe need change height? |
|
@WhiteEagle88 As the logo is square, both width and height should be the same IMHO. |
4032755 to
d120c08
Compare
|
@fabpot For symfony 3.0 will need to create pull request? |
|
Could any Windows user please verify this fix? Thanks! |
|
I'm sorry, I don't have Windows 10 so no Edge for me. |
|
Works well for me, Windows 10 Microsoft Edge 25.10586.0.0 with EdgeHTML 13.10586
|
|
@AlexandrePavy thanks for confirming the fix! And thanks to @WhiteEagle88 for fixing it. |
|
Thank you @WhiteEagle88. |
fabpot
added a commit
that referenced
this pull request
Feb 8, 2016
…dge (WhiteEagle88) This PR was merged into the 2.8 branch. Discussion ---------- [WebProfiler] Fixed logo and menu profiler for Microsoft Edge | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #16887 | License | MIT | Doc PR | - Commits ------- d120c08 [WebProfiler] Fixed styles for search block and menu profiler for IE Edge
ostrolucky
pushed a commit
to ostrolucky/symfony
that referenced
this pull request
Mar 25, 2018
…osoft Edge (WhiteEagle88) This PR was merged into the 2.8 branch. Discussion ---------- [WebProfiler] Fixed logo and menu profiler for Microsoft Edge | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | symfony#16887 | License | MIT | Doc PR | - Commits ------- d120c08 [WebProfiler] Fixed styles for search block and menu profiler for IE Edge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.