[DependencyInjection][Routing] add files used in FileResource objects #17672
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Starting with Symfony 3.1, the constructor of the `FileResource` class will throw an exception when the passed file does not exist.
|
ping @symfony/deciders (we need this to make the test suite pass again for all branches on Travis) |
|
Thank you @xabbuh. |
nicolas-grekas
added a commit
that referenced
this pull request
Feb 4, 2016
…rce objects (xabbuh) This PR was merged into the 2.3 branch. Discussion ---------- [DependencyInjection][Routing] add files used in FileResource objects | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #17598 (comment) | License | MIT | Doc PR | Starting with Symfony 3.1, the constructor of the `FileResource` class will throw an exception when the passed file does not exist. Commits ------- 4f865c7 add files used in FileResource objects
This was referenced Feb 28, 2016
Merged
Merged
Merged
Merged
|
Just to add this as a side-note: I also had a problem that was fixed by these lines here. My usecase was like following: I had a class in my self-written extension, that extended a native PHP class. Thereby the parent-class hasn't had a valid includable file. The result now was, that the cache, containing the dependencies merged in a single file, was rebuild all the time, because the timestamp of that file couldn't be checked. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting with Symfony 3.1, the constructor of the
FileResourceclasswill throw an exception when the passed file does not exist.