[Routing] add files used in FileResource objects #17673
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Starting with Symfony 3.1, the constructor of the `FileResource` class will throw an exception when the passed file does not exist.
|
ping @symfony/deciders (we need this to make the test suite pass again for all branches on Travis) |
|
This fix looks correct at first sight: +if (is_file($class->getFileName())) {
$collection->addResource(new FileResource($class->getFileName()));
+}But my question is: do we want to fix problems silently or do we want to fail hard and notify the user? |
|
Thank you @xabbuh. |
nicolas-grekas
added a commit
that referenced
this pull request
Feb 4, 2016
This PR was merged into the 2.8 branch. Discussion ---------- [Routing] add files used in FileResource objects | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #17598 (comment) | License | MIT | Doc PR | Starting with Symfony 3.1, the constructor of the `FileResource` class will throw an exception when the passed file does not exist. Commits ------- 73afd0f add files used in FileResource objects
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting with Symfony 3.1, the constructor of the
FileResourceclasswill throw an exception when the passed file does not exist.