[TwigBridge] forward compatibility with Yaml 3.1 #17702
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
xabbuh
commented
Feb 5, 2016
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | |
| License | MIT |
| Doc PR |
|
👍 We may even want to apply this in older branches |
|
Indeed, I missed that the requirement is only in |
|
Why backporting to older branches ? Their composer.json make them not compatible with 3.1, so this would always evaluate to false, isn't it? |
|
@nicolas-grekas I do not see what would prevent someone to use the TwigBridge in Symfony 2.3 together with the Yaml component from 3.1. Do I miss something? |
|
Nevermind, I didn't understand you above statement about the req being in |
|
oh okay :) |
|
Thank you @xabbuh. |
nicolas-grekas
added a commit
that referenced
this pull request
Feb 5, 2016
This PR was submitted for the 3.0 branch but it was merged into the 2.3 branch instead (closes #17702). Discussion ---------- [TwigBridge] forward compatibility with Yaml 3.1 | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | Commits ------- 047c195 [TwigBridge] forward compatibility with Yaml 3.1
This was referenced Feb 28, 2016
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.