[TwigBridge] deprecate the boolean object support trigger #17705
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
531ee2f to
27243c6
Compare
|
Thank you @xabbuh. |
fabpot
added a commit
that referenced
this pull request
Feb 6, 2016
…ger (xabbuh) This PR was merged into the 3.1-dev branch. Discussion ---------- [TwigBridge] deprecate the boolean object support trigger | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | This reflects the changes done in the Yaml component in #17578. Commits ------- 27243c6 deprecate the boolean object support trigger
|
@xabbuh tests are failing with this :) |
|
too bad :( see #17712 for the fix |
xabbuh
added a commit
that referenced
this pull request
Feb 7, 2016
This PR was merged into the 3.1-dev branch. Discussion ---------- [TwigBridge] fix default argument value | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #17705 | License | MIT | Doc PR | When deprecating boolean argument values, the default value must not be `false`. Commits ------- beea61e [TwigBridge] fix default argument value
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reflects the changes done in the Yaml component in #17578.