[DependencyInjection] Fix #16461 Container::set() replace aliases #17742
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…existing aliases `Container::set()` now overrides any previously alias defined with the same name.
|
👍 Status: Reviewed |
|
Thank you @mnapoli. |
fabpot
added a commit
that referenced
this pull request
Feb 12, 2016
…aliases (mnapoli) This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes #17742). Discussion ---------- [DependencyInjection] Fix #16461 Container::set() replace aliases | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #16461 | License | MIT | Doc PR | - `Container::set()` now overrides any previously alias defined with the same name. Please see #16461 for the background. Example: - given `event_dispatcher` is an alias to `debug.event_dispatcher` - when I run: `$container->set('event_dispatcher', new FakeEventDispatcher)` - *before this patch*: nothing happens - *after this patch*: the `event_dispatcher` is now my fake event dispatcher Commits ------- be85d16 [DependencyInjection] Fix #16461 Let Container::set() replace existing aliases
This was referenced Feb 28, 2016
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Container::set()now overrides any previously alias defined with the same name. Please see #16461 for the background.Example:
event_dispatcheris an alias todebug.event_dispatcher$container->set('event_dispatcher', new FakeEventDispatcher)event_dispatcheris now my fake event dispatcher