[Yaml] dumper flag for enabling exceptions on invalid type #17743
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
xabbuh
commented
Feb 9, 2016
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | yes |
| Tests pass? | yes |
| Fixed tickets | |
| License | MIT |
| Doc PR | symfony/symfony-docs#6226 |
e450453 to
5c58bc6
Compare
b5a9312 to
a029822
Compare
a029822 to
e572a64
Compare
|
👍 |
| @@ -39,9 +40,16 @@ public function encode($input, $inline = 0, $dumpObjects = 0) | |||
| $dumper = new YamlDumper(); | |||
| } | |||
|
|
|||
| if (defined('Symfony\Component\Yaml\Yaml::DUMP_OBJECT') && is_bool($dumpObjects)) { | |||
| @trigger_error('Passing a boolean flag to toggle object support is deprecated since version 3.1 and will be removed in 4.0. Use the Yaml::DUMP_OBJECT flag instead.', E_USER_DEPRECATED); | |||
| $dumpObjects = (int) $dumpObjects; | |||
There was a problem hiding this comment.
As we appplied this change in 2.x branches too (to avoid deprecation warnings when using highest deps), this should be changed there too.
There was a problem hiding this comment.
Yes, I'll create a separate pull request when this one is merged.
|
Thank you @xabbuh. |
fabpot
added a commit
that referenced
this pull request
Feb 12, 2016
…type (xabbuh) This PR was merged into the 3.1-dev branch. Discussion ---------- [Yaml] dumper flag for enabling exceptions on invalid type | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | Commits ------- e572a64 dumper flag to enable exceptions on invalid types
fabpot
added a commit
that referenced
this pull request
Feb 14, 2016
This PR was merged into the 2.3 branch. Discussion ---------- [TwigBridge] Symfony 3.1 forward compatibility | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #17743 (comment) | License | MIT | Doc PR | Commits ------- 2991639 [TwigBridge] Symfony 3.1 forward compatibility
7 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.