[DomCrawler] Remove the overridden getHash() method to prevent problems when cloning the crawler #17748
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ms when cloning the crawler Overriding the SplObjectStorage::getHash() is affected by a PHP bug (https://bugs.php.net/bug.php?id=67582), which makes the Crawler unusable in Symfony 2.8 for anyone who relied on SplObjectStorage methods. Removing the getHash() method means we will no longer trigger the deprecation error. Given this method is unlikely to be used directly and other SplObjectStorage methods will trigger the error, it is the simplest thing we can do to maintain BC.
|
👍 status: reviewed |
|
👍 Status: Reviewed |
jakzal
added a commit
that referenced
this pull request
Feb 10, 2016
…vent problems when cloning the crawler (jakzal) This PR was merged into the 2.8 branch. Discussion ---------- [DomCrawler] Remove the overridden getHash() method to prevent problems when cloning the crawler | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #16421 | License | MIT | Doc PR | - Overriding the `SplObjectStorage::getHash()` is affected by a [PHP bug](https://bugs.php.net/bug.php?id=67582), which makes the Crawler unusable in Symfony 2.8 for anyone who relied on `SplObjectStorage` methods. Removing the `getHash()` method means we will no longer trigger the deprecation error. Given this method is unlikely to be used directly and other `SplObjectStorage` methods will trigger the error, it is the simplest thing we can do to maintain BC. Commits ------- 3d7f6c6 [DomCrawler] Remove the overridden getHash() method to prevent problems when cloning the crawler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overriding the
SplObjectStorage::getHash()is affected by a PHP bug, which makes the Crawler unusable in Symfony 2.8 for anyone who relied onSplObjectStoragemethods.Removing the
getHash()method means we will no longer trigger the deprecation error. Given this method is unlikely to be used directly and otherSplObjectStoragemethods will trigger the error, it is the simplest thing we can do to maintain BC.