[Console] InvalidArgumentException is thrown under wrong condition #17818
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…able AND doesn't implement Countable, not when it doesn't implement Traversable but DOES implement Countable
|
👍 Status: Reviewed |
|
👍 but this must be merged into 2.7 |
|
Shall I make a new PR or will someone merge manually? |
|
Someone will merge this manually in the correct branch. |
|
Okay thanks On Tue, Feb 16, 2016, 23:12 Diego Saint Esteben notifications@github.com
|
|
Thank you @robinkanters. |
fabpot
added a commit
that referenced
this pull request
Feb 17, 2016
…ondition (robinkanters) This PR was submitted for the master branch but it was merged into the 2.7 branch instead (closes #17818). Discussion ---------- [Console] InvalidArgumentException is thrown under wrong condition | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | N/A | License | MIT | Doc PR | no When an object is passed to `setAutocompleterValues` that implements `\Countable` and `\Traversable`, an `InvalidArgumentException` is thrown, even though its message says that the argument should implement both of those interfaces. Instead, the exception should be thrown if the parameter fails to implement either `\Countable` or `\Traversable`, like the exception message says. _Disclaimer: I've been looking at this line for 10min, and I've become convinced it should be changed according to my PR, but I could be wrong._ Commits ------- 8eea65e The exception should be thrown if an object doesn't implement Traversable AND doesn't implement Countable, not when it doesn't implement Traversable but DOES implement Countable
This was referenced Feb 28, 2016
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an object is passed to
setAutocompleterValuesthat implements\Countableand\Traversable, anInvalidArgumentExceptionis thrown, even though its message says that the argument should implement both of those interfaces.Instead, the exception should be thrown if the parameter fails to implement either
\Countableor\Traversable, like the exception message says.Disclaimer: I've been looking at this line for 10min, and I've become convinced it should be changed according to my PR, but I could be wrong.