[HttpKernel] Prevent a fatal error when DebugHandlersListener is used with a kernel with no terminateWithException() method #17819
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -93,7 +93,9 @@ public function configure(Event $event = null) | |||
| } | |||
| if (!$this->exceptionHandler) { | |||
| if ($event instanceof KernelEvent) { | |||
| $this->exceptionHandler = array($event->getKernel(), 'terminateWithException'); | |||
| if (is_callable(array($event->getKernel(), 'terminateWithException'))) { | |||
There was a problem hiding this comment.
IHMO, method_exists would be more straightforward here
There was a problem hiding this comment.
Wouldn't it return true if the method was private?
There was a problem hiding this comment.
yes, but I'd say we don't care, we already use method_exists in the code base and that doesn't cause any issue I think
There was a problem hiding this comment.
Fair enough. Updated.
There was a problem hiding this comment.
and is_callable would return true as soon there is __call even though the implementation does not support it, so it is not a silver-bullet either.
… with a kernel with no terminateWithException() method
b774445 to
2849152
Compare
|
👍 failures look unrelated |
|
👍 Status: Reviewed |
|
Thank you @jakzal. |
fabpot
added a commit
that referenced
this pull request
Feb 17, 2016
…ner is used with a kernel with no terminateWithException() method (jakzal) This PR was merged into the 2.7 branch. Discussion ---------- [HttpKernel] Prevent a fatal error when DebugHandlersListener is used with a kernel with no terminateWithException() method | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - I just suffered from this bug on a project that used HttpKernelInterface implementation with no `terminateWithException() method (which is not part of the interface). Commits ------- 2849152 [HttpKernel] Prevent a fatal error when DebugHandlersListener is used with a kernel with no terminateWithException() method
This was referenced Feb 28, 2016
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just suffered from this bug on a project that used HttpKernelInterface implementation with no `terminateWithException() method (which is not part of the interface).