Fixed the antialiasing of the toolbar text #17860
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 Status: Reviewed |
|
Thank you @javiereguiluz. |
fabpot
added a commit
that referenced
this pull request
Feb 20, 2016
This PR was merged into the 2.8 branch. Discussion ---------- Fixed the antialiasing of the toolbar text | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - ### Problem The Symfony toolbar looks ugly in some situations (the text is too thin and unreadable); for example inside a SonataAdmin backend: (top: toolbar in a normal page; bottom: toolbar in Sonata backend; if you don't see any difference, click on the image to zoom it) #### Chrome  #### Firefox  ### Solution The cause of this problem are the styles applied by the popular AdminLTE template used by Sonata and other admin bundles. The proposed changes neutralize any aliasing set by external CSS styles, so the toolbar is always displayed the same way: #### Chrome  #### Firefox  Commits ------- 5ad065d Fixed the antialiasing of the toolbar text
javiereguiluz
added a commit
to EasyCorp/EasyAdminBundle
that referenced
this pull request
Feb 24, 2016
This PR was merged into the master branch. Discussion ---------- Make the Symfony Debug toolbar look always nice This is a port of symfony/symfony#17860 to fix how the Symfony Debug Toolbar looks inside EasyAdmin. I want to include this fix in our CSS styles because that will make the Symfony toolbar look always nice inside EasyAdmin. Otherwise, only people with the latest Symfony versions will see it right. Commits ------- 2c61ae7 Make the Symfony Debug toolbar look always nice
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The Symfony toolbar looks ugly in some situations (the text is too thin and unreadable); for example inside a SonataAdmin backend:
(top: toolbar in a normal page; bottom: toolbar in Sonata backend; if you don't see any difference, click on the image to zoom it)
Chrome
Firefox
Solution
The cause of this problem are the styles applied by the popular AdminLTE template used by Sonata and other admin bundles. The proposed changes neutralize any aliasing set by external CSS styles, so the toolbar is always displayed the same way:
Chrome
Firefox