[Serializer] Harden the ObjectNormalizer #17959
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -21,7 +21,7 @@ | |||
| "require-dev": { | |||
| "symfony/yaml": "~2.8|~3.0", | |||
| "symfony/config": "~2.8|~3.0", | |||
| "symfony/property-access": "~2.8|~3.0", | |||
| "symfony/property-access": "~3.1", | |||
There was a problem hiding this comment.
IIUC, this is "just" to make the test pass, right? The code change itself does not need that. So, IMO, we should keep the constraint as is and tweak the test instead.
|
Status: needs work |
fc84692 to
5d4d0a6
Compare
|
Status: needs review |
|
You have update the minimum version required for the PropertyAccess component in the Status: Needs work |
|
Travis and AppVeyor not related. Ping @symfony/deciders |
| @@ -27,6 +27,9 @@ | |||
| "doctrine/annotations": "~1.0", | |||
| "doctrine/cache": "~1.0" | |||
| }, | |||
| "conflict": { | |||
| "symfony/property-access": ">=3.0,<3.0.4|>=2.8,<2.8.4" | |||
There was a problem hiding this comment.
Then I would rather update the constraint in require-devto ~2.8,>=2.8.4|~3.0,>=3.0.4.
There was a problem hiding this comment.
Why? The conflict line has the same effect and works in prod too.
|
👍 for 3.1. The composer.json update is fine to me. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Transform
\TypeErrors to catchable serializer exceptions.Follows #17738 and completes #17660.