Allow to normalize \Traversable when serializing xml #17984
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ping @dunglas |
| $serializer = new Serializer(array(new CustomNormalizer()), array('xml' => new XmlEncoder())); | ||
| $this->encoder->setSerializer($serializer); | ||
|
|
||
| $expected = '<?xml version="1.0"?>'."\n". |
There was a problem hiding this comment.
Can use the heredoc syntax for clarity.
|
👍 |
|
It should be tested but it looks like a good idea. |
|
Thank you @Ener-Getick. |
fabpot
added a commit
that referenced
this pull request
Mar 4, 2016
…-Getick) This PR was merged into the 2.3 branch. Discussion ---------- Allow to normalize \Traversable when serializing xml | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | no | Fixed tickets | | License | MIT It's impossible to normalize an object implementing ``\Traversable`` when using the ``XMLEncoder``. For example we can't customize the serializer output when serializing a ``FormInterface`` instance. So my proposition is to fix this by using the default XML encoder output only when the serializer can't normalize the data. Commits ------- 97c5d27 Allow to normalize \Traversable
|
@Ener-Getick I've merged this one as this is a bug fix. Feel free to open a new PR for the other change if it makes sense. |
Merged
This was referenced Mar 25, 2016
Merged
Closed
Merged
Merged
xabbuh
added a commit
to FriendsOfSymfony/FOSRestBundle
that referenced
this pull request
Apr 25, 2016
This PR was merged into the 2.0 branch. Discussion ---------- Removes a hack Removes a hack as symfony/symfony#17984 has been merged. Commits ------- 7bcd70b Remove a hack
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's impossible to normalize an object implementing
\Traversablewhen using theXMLEncoder. For example we can't customize the serializer output when serializing aFormInterfaceinstance.So my proposition is to fix this by using the default XML encoder output only when the serializer can't normalize the data.