[Routing] Add matched and default parameters to redirect responses #18012
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
artursvonda
commented
Mar 4, 2016
| Q | A |
|---|---|
| Branch | 2.3 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | |
| License | MIT |
| Doc PR |
| } | ||
|
|
||
| // baz2 | ||
| if ($pathinfo === '/test/baz.html') { | ||
| return array('_route' => 'baz2'); | ||
| $ret = array('_route' => 'baz2'); | ||
| return $ret; |
There was a problem hiding this comment.
Are those changes intended ? You should revert them.
There was a problem hiding this comment.
This is a fixture file and the code is generated, this is intended.
|
👍 |
|
Original PR is #11380 |
|
Is this now considered a bug fix or a new feature (I seem to miss the conclusion in #11380)? |
|
@Tobion Can you give us your opinion on this PR? |
|
I finished it in #19037. Rebased against master as it didn't apply cleanly and fixed adding the route params for the slash redirect as well. This was only done in the dumped version but not in the RedirectableUrlMatcher directly. |
nicolas-grekas
added a commit
that referenced
this pull request
Jul 11, 2017
…ct responses (artursvonda, Tobion) This PR was merged into the 3.4 branch. Discussion ---------- [Routing] Add matched and default parameters to redirect responses | Q | A | | --- | --- | | Branch? | master | | Bug fix? | no | | New feature? | yes | | BC breaks? | no | | Deprecations? | no | | Tests pass? | yes | | Fixed tickets | #18012, #19037 | | License | MIT | | Doc PR | | Finished #18012 and #19037 Commits ------- 4c1fdd4 [Routing] also add matched params for redirect due to trailing slash dc3f7a9 [Routing] Add matched and default parameters to redirect responses
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.