[2.7][Process] Fix memory issue when using large input streams #18015
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| $data .= $dataread; | ||
| } | ||
| // Remove extra null chars returned by fread | ||
| if ($data !== '') { |
There was a problem hiding this comment.
Replace it by if ('' !== $data) { for consistency?
|
Tests are okay on component process on both CI |
|
👍 |
|
Thank you @romainneutron. |
fabpot
added a commit
that referenced
this pull request
Mar 6, 2016
…eams (romainneutron) This PR was merged into the 2.7 branch. Discussion ---------- [2.7][Process] Fix memory issue when using large input streams | Q | A | ------------- | --- | Branch | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #17667 | License | MIT This removes buffering of a stream input. Tests shows that this implementation is much faster and fixes some issues when streams are based on very large inputs Commits ------- fb8da9f [Process] Fix memory issue when using large input streams
fabpot
added a commit
that referenced
this pull request
Mar 10, 2016
This PR was merged into the 2.7 branch. Discussion ---------- [Process] Fix pipes handling | Q | A | ------------- | --- | Branch | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #18015 | License | MIT | Doc PR | - Commits ------- 3ab6c39 [Process] Fix pipes handling
This was referenced Mar 25, 2016
Merged
Closed
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes buffering of a stream input. Tests shows that this implementation is much faster and fixes some issues when streams are based on very large inputs