[Intl] Update ICU to version 55 #18019
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some form tests are failing. status: needs work |
|
Form tests updated. Failure on appveyor is unrelated. status: needs review |
| @@ -1,5 +1,5 @@ | |||
| { | |||
| "Version": "2.1.8.20", | |||
| "Version": "2.1.13.24", | |||
| "Names": { | |||
| "aa": "Afarski", | |||
| "ab": "abhaski", | |||
There was a problem hiding this comment.
is the case here intended ?
There was a problem hiding this comment.
This is a generated file.
There was a problem hiding this comment.
It's better to review this PR commit by commit. "[Intl] Update the ICU data to version 55" is an update for generated files.
|
This is big. Great work! |
|
Thank you @jakzal. |
fabpot
added a commit
that referenced
this pull request
Mar 6, 2016
This PR was merged into the 2.3 branch. Discussion ---------- [Intl] Update ICU to version 55 | Q | A | ------------- | --- | Branch | 2.3 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #14260 | License | MIT | Doc PR | - The update script needed to be fixed to work with latest data files from ICU as well. The only change I needed to do in stubs and tests is related to the way negative numbers are formatted for currencies (a change from `(£100)` to `-£100`). Form tests needed an update as well, as some date formats have changed. Commits ------- fac3de6 [Form] Update form tests after the ICU data update 6822147 [Intl] Update tests and the number formatter to match behaviour of the intl extension 37a9d8c [Intl] Update the ICU data to version 55 894ce3c [Intl] Fix the update-data.php script in preparation for ICU 5.5
Closed
|
Awesome @jakzal, thanks so much! :) |
Merged
This was referenced Mar 25, 2016
Merged
Closed
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The update script needed to be fixed to work with latest data files from ICU as well.
The only change I needed to do in stubs and tests is related to the way negative numbers are formatted for currencies (a change from
(£100)to-£100).Form tests needed an update as well, as some date formats have changed.