[HttpFoundation] Add a dependency on the mbstring polyfill #18030
Conversation
f96ebb9 to
f92756f
Compare
| @@ -36,6 +36,7 @@ public function testConstruction() | |||
|
|
|||
| public function testConstructWithNonAsciiFilename() | |||
| { | |||
| var_dump(scandir(__DIR__.'/Fixtures/')); | |||
There was a problem hiding this comment.
Just debugging. I'm not exactly sure why this fails on windows :)
f92756f to
40467f7
Compare
bff17a0 to
4e51e73
Compare
|
Tests pass everywhere now. In order for file names with non-ascii characters work on all platforms they need to be created from PHP (just like we do it in FileTest). Status: needs review |
|
We can now also remove the fixtures file that is not used anymore, can't we? |
|
It's used in the other test. |
|
|
||
| $this->assertSame('fööö.html', $response->getFile()->getFilename()); | ||
|
|
||
| @unlink(sys_get_temp_dir().'/fööö.html'); |
There was a problem hiding this comment.
We should remove the file before the assertion. Otherwise it wouldn't be removed when the assertion failed.
|
Hm indeed, can't we reuse the same approach in that test? |
A file with non-ascii characters in the name needs to be created from PHP in order for it to be read properly on all platforms.
4e51e73 to
e3eb4f9
Compare
|
@xabbuh actually, the other test didn't need the file to exist, as only the file name is used there. I removed the fixture. |
|
@symfony/deciders this PR, when merged, will fix the build |
|
👍 Status: Reviewed |
|
Thank you @jakzal. |
…ll (jakzal) This PR was squashed before being merged into the 2.3 branch (closes #18030). Discussion ---------- [HttpFoundation] Add a dependency on the mbstring polyfill | Q | A | ------------- | --- | Branch | 2.3 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? |no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Alternative for #18029. Commits ------- 59b9f15 [HttpFoundation] Add a dependency on the mbstring polyfill
Alternative for #18029.