[Serializer] XmlEncoder: Make load flags configurable #18036
Conversation
dunglas
commented
Mar 6, 2016
| Q | A |
|---|---|
| Branch | master |
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #17987 |
| License | MIT |
| Doc PR | todo |
| { | ||
| $this->rootNodeName = $rootNodeName; | ||
| $this->loadOptions = $loadOptions ?: LIBXML_NONET | LIBXML_NOBLANKS; |
There was a problem hiding this comment.
$this->loadOptions = null !== $loadOptions ?: LIBXML_NONET | LIBXML_NOBLANKS;
There was a problem hiding this comment.
oh wait, the suggestion was bad, it must now be $this->loadOptions = null !== $loadOptions ? $loadOptions : LIBXML_NONET | LIBXML_NOBLANKS;
There was a problem hiding this comment.
I copy/pasted without care, sorry. It's fixed now.
| @@ -80,8 +83,10 @@ public function decode($data, $format, array $context = array()) | |||
| $disableEntities = libxml_disable_entity_loader(true); | |||
| libxml_clear_errors(); | |||
|
|
|||
| $loadOptions = isset($context['xml_load_options']) ? $context['xml_load_options'] : $this->loadOptions; | |||
There was a problem hiding this comment.
Is it really a good idea to make this overridable through the context?
There was a problem hiding this comment.
I think you're right, I'll update the PR.
|
ping @symfony/deciders |
|
|
||
| /** | ||
| * Construct new XmlEncoder and allow to change the root node element name. | ||
| * | ||
| * @param string $rootNodeName | ||
| * @param string $rootNodeName | ||
| * @param int|null $loadOptions |
There was a problem hiding this comment.
We should add a short explanation what $loadOptions means (something like "a bit field of LIBXML_ constants").
|
👍 (apart from my last minor comment) |
|
@xabbuh comment added |
|
Thank you @dunglas. |
…(dunglas) This PR was squashed before being merged into the 3.1-dev branch (closes #18036). Discussion ---------- [Serializer] XmlEncoder: Make load flags configurable | Q | A | ------------- | --- | Branch | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #17987 | License | MIT | Doc PR | todo Commits ------- 0826068 [Serializer] XmlEncoder: Make load flags configurable
|
Great 👍 Can someone point me in the direction how to override this settings for |
|
Add this class with the new options as a new encoder: http://symfony.com/doc/current/cookbook/serializer.html#adding-normalizers-and-encoders |