Skip to content

[2.7] update readme files for new components #18044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 7, 2016

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Mar 7, 2016

Q A
Branch 2.7
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #17997
License MIT
Doc PR

This completes @javiereguiluz's great work from #17997 by adapting the readme files of components added after the release of Symfony 2.3.

@xabbuh
Copy link
Member Author

xabbuh commented Mar 7, 2016

Oh, we need to take into account the split of the Security component too.

Status: Needs Work

echo $language->compile('"foo" ~ upper(foo)');
// would output ("foo" . strtoupper($foo))
evaluate expressions. An expression is a one-liner that returns a value
(mostly, but not limited to, Booleans).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Booleans and scalars ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reused the introduction from the documentation: http://symfony.com/doc/current/components/expression_language/introduction.html

I think if we want to improve this (which doesn't seem to be the worst idea), we should make the change there first.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @xabbuh. Let's copy the current description to move forward fast and let's improve it in the future.

@xabbuh
Copy link
Member Author

xabbuh commented Mar 7, 2016

Security sub-components updated too.

Status: Needs Review

Resources
---------

* [Documentation](http://symfony.com/doc/current/components/phpunit_bridge.html)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use https:// in this link.

@xabbuh
Copy link
Member Author

xabbuh commented Mar 7, 2016

@javiereguiluz Thanks for the heads up. Fixed all the links.

@javiereguiluz
Copy link
Member

👍

Status: Reviewed

@nicolas-grekas
Copy link
Member

Thank you @xabbuh.

@nicolas-grekas nicolas-grekas merged commit 5ba194e into symfony:2.7 Mar 7, 2016
nicolas-grekas added a commit that referenced this pull request Mar 7, 2016
This PR was merged into the 2.7 branch.

Discussion
----------

[2.7] update readme files for new components

| Q             | A
| ------------- | ---
| Branch        | 2.7
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #17997
| License       | MIT
| Doc PR        |

This completes @javiereguiluz's great work from #17997 by adapting the readme files of components added after the release of Symfony 2.3.

Commits
-------

5ba194e [2.7] update readme files for new components
@xabbuh xabbuh deleted the readme-2.7 branch March 7, 2016 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants