[Validator] Fix the locale validator so it treats a locale alias as a valid locale #18049
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jakzal
commented
Mar 7, 2016
| Q | A |
|---|---|
| Branch | 2.3 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #12583 |
| License | MIT |
| Doc PR | - |
649c17e to
f3ed390
Compare
f3ed390 to
3854889
Compare
| @@ -22,7 +22,7 @@ | |||
| "require-dev": { | |||
| "doctrine/common": "~2.3", | |||
| "symfony/http-foundation": "~2.1", | |||
| "symfony/intl": "~2.3", | |||
| "symfony/intl": "^2.3.21", | |||
There was a problem hiding this comment.
LocaleBundle::getAliases() was introduced in Symfony 2.3.21. Without this tests with --prefer-lowest fail.
|
|
||
| if (!isset($locales[$value])) { | ||
| if (!isset($locales[$value]) && !array_search($value, $aliases)) { |
There was a problem hiding this comment.
As we are not interested in the index wouldn't it be make sense to use in_array() instead?
3854889 to
fbb12d8
Compare
|
👍 Status: Reviewed |
|
👍 |
|
Thank you @jakzal. |
fabpot
added a commit
that referenced
this pull request
Mar 8, 2016
… alias as a valid locale (jakzal) This PR was merged into the 2.3 branch. Discussion ---------- [Validator] Fix the locale validator so it treats a locale alias as a valid locale | Q | A | ------------- | --- | Branch | 2.3 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #12583 | License | MIT | Doc PR | - Commits ------- fbb12d8 [Validator] Fix the locale validator so it treats a locale alias as a valid locale
Merged
This was referenced Mar 25, 2016
Merged
Closed
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.