Skip to content

[WebProfiler] Sidebar button padding #18087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 10, 2016
Merged

[WebProfiler] Sidebar button padding #18087

merged 1 commit into from
Mar 10, 2016

Conversation

rvanlaak
Copy link
Contributor

Q A
Branch 2.8
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR

Before

image

After

image

@javiereguiluz
Copy link
Member

I can't reproduce this issue, but I obviously give it a 👍

@rvanlaak I have another question: the Search button is slightly taller than the other buttons (I guess because of the icon). Could you please check if this can be solved in a simple way to include the fix in this pull request too? Thanks!

@rvanlaak
Copy link
Contributor Author

@javiereguiluz you are right about the svg, it actually was the reason for the behavior as seen in the screenshots. The svg icons should always have height and width. Fixed it for another occurrence too.

@fabpot
Copy link
Member

fabpot commented Mar 10, 2016

Thank you @rvanlaak.

@fabpot fabpot merged commit 0862334 into symfony:2.8 Mar 10, 2016
fabpot added a commit that referenced this pull request Mar 10, 2016
This PR was merged into the 2.8 branch.

Discussion
----------

[WebProfiler] Sidebar button padding

| Q             | A
| ------------- | ---
| Branch        | 2.8
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

**Before**

![image](https://cloud.githubusercontent.com/assets/2707563/13665247/bb57b9c8-e6ab-11e5-8347-d26239bab06f.png)

**After**

![image](https://cloud.githubusercontent.com/assets/2707563/13665273/dfbbf860-e6ab-11e5-959c-2a56c6e1b7e5.png)

Commits
-------

0862334 [WebProfiler] Sidebar button padding
@rvanlaak rvanlaak deleted the patch-7 branch March 23, 2016 19:47
This was referenced Mar 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants