[Yaml] fix DateTime tests #18093
Closed
[Yaml] fix DateTime tests #18093
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@xabbuh have you tried changing your local timezone to reproduce the problem? |
|
@jakzal Yes, but the result was the same. |
|
The issue is that PHP 5.5.14+ handles sub-seconds whereas previous PHP did not: |
Merged
|
closing in favour of #18098 |
nicolas-grekas
added a commit
that referenced
this pull request
Mar 10, 2016
This PR was merged into the 3.1-dev branch. Discussion ---------- [Yaml] Fix tests | Q | A | ------------- | --- | Branch | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | no | Fixed tickets | #18093 | License | MIT | Doc PR | - `now` contains a TZ info (the current default TZ), so that the following ignores the injected TZ: `new \DateTime('now', new \DateTimeZone('UTC'))` An other fix is that since PHP 5.5.14, timestamps contains sub-seconds numbers that where previously ignore. This fixes both issues. Commits ------- 25677fe [Yaml] Fix tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please note: This is mainly a workaround for the failing tests in the component. I was not able to reproduce the failures locally nor do I have a clue why this happens. So I'd be glad if someone can come up with an explanation for this behaviour which confirms that this is the right fix or that we should fix it in another way.