[Debug] Replaced logic for detecting filesystem case sensitivity #18126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 12, 2016 15:24
When I cloned the master branch onto a Virtualbox Vagrant OSX El Capitan host, Ubuntu Wily guest, the `Symfony\Component\Debug\Tests\DebugClassLoaderTest::testFileCaseMismatch` failed because 'Failed asserting that exception of type "\RuntimeException" is thrown'. @wouterj confirmed he got the same problem, and it's because Virtualbox shared folders aren't case sensitive, even when the guest is using a case sensitive filesystem. So I've replaced the logic that looked at the name of the operating system. I ran the tests in the following environments: * Virtualbox/Vagrant - OSX Host, Ubuntu guest * Virtualbox/Vagrant - OSX Host, Windows guest * OSX native * Ubuntu native NB - I _didn't_ run it on native Windows (because I don't have easy access to one).
When I cloned the master branch onto a Virtualbox Vagrant OSX El Capitan host, Ubuntu Wily guest, the `Symfony\Component\Debug\Tests\DebugClassLoaderTest::testFileCaseMismatch` failed because 'Failed asserting that exception of type "\RuntimeException" is thrown'. @wouterj confirmed he got the same problem, and it's because Virtualbox shared folders aren't case sensitive, even when the guest is using a case sensitive filesystem. So I've replaced the logic that looked at the name of the operating system. I ran the tests in the following environments: * Virtualbox/Vagrant - OSX Host, Ubuntu guest * Virtualbox/Vagrant - OSX Host, Windows guest * OSX native * Ubuntu native NB - I _didn't_ run it on native Windows (because I don't have easy access to one).
|
@blowski thank you for contributing to Symfony! Before reviewing your pull request, I'd like to comment you two little things:
In this case it's a bug so: if 2.3 suffers this problem, select
|
|
@javiereguiluz Thank you - I just had a chat with @weaverryan and he said the same thing, so I created another PR against 2.7 (#18130). And I fixed the message as well, sorry about that. Thanks for organising today by the way, really useful. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I cloned the master branch onto a Virtualbox Vagrant OSX El Capitan host, Ubuntu Wily guest, the
Symfony\Component\Debug\Tests\DebugClassLoaderTest::testFileCaseMismatchfailed because 'Failed asserting that exception of type "\RuntimeException" is thrown'.@wouterj confirmed he got the same problem, and it's because Virtualbox shared folders aren't case sensitive, even when the guest is using a case sensitive filesystem. So I've replaced the logic that looked at the name of the operating system.
I ran the tests in the following environments:
NB - I didn't run it on native Windows (because I don't have easy access to one).