[Form] Fix NumberToLocalizedStringTransformer::reverseTransform with big integers #18179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nicolas-grekas
commented
Mar 15, 2016
| Q | A |
|---|---|
| Branch | 2.3 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #18077, #18067 |
| License | MIT |
| Doc PR | - |
| if (false !== strpos($value, $decSep)) { | ||
| $type = \NumberFormatter::TYPE_DOUBLE; | ||
| } else { | ||
| $type = PHP_INT_SIZE === 8 |
There was a problem hiding this comment.
Very minor comment: should this ternary condition be a one-liner?
There was a problem hiding this comment.
it wouldn't enhance readability imho
nicolas-grekas
added a commit
that referenced
this pull request
Mar 15, 2016
…sform with big integers (ovrflo, nicolas-grekas) This PR was merged into the 2.3 branch. Discussion ---------- [Form] Fix NumberToLocalizedStringTransformer::reverseTransform with big integers | Q | A | ------------- | --- | Branch | 2.3 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #18077, #18067 | License | MIT | Doc PR | - Commits ------- 03c008c [Form] Fix NumberToLocalizedStringTransformer::reverseTransform with big integers 6b6073f [Form] Fix INT64 cast to float in IntegerType.
This was referenced Mar 25, 2016
Merged
Closed
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.