use the clock mock for progress indicator tests #18200
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
xabbuh
commented
Mar 16, 2016
| Q | A |
|---|---|
| Branch? | 3.0 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #15617 (comment) |
| License | MIT |
| Doc PR |
| @@ -11,7 +11,7 @@ | |||
| */ | |||
|
|
|||
| // Please update when phpunit needs to be reinstalled with fresh deps: | |||
| // Cache-Id-Version: 2016-03-16 15:36 UTC | |||
| // Cache-Id-Version: 2016-03-16 16:33 UTC | |||
There was a problem hiding this comment.
no need to change, the cached one is good
There was a problem hiding this comment.
I thought this is necessary every time we change the PHPUnit configuration file, isn't it?
There was a problem hiding this comment.
it's required when you need to force a reload of phpunit or any of its dependencies, not the case here
|
failure on AppVeyor is unrelated |
a60f28f to
dbde648
Compare
|
👍 |
|
Thank you @xabbuh. |
nicolas-grekas
added a commit
that referenced
this pull request
Mar 16, 2016
This PR was merged into the 3.0 branch. Discussion ---------- use the clock mock for progress indicator tests | Q | A | ------------- | --- | Branch? | 3.0 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #15617 (comment) | License | MIT | Doc PR | Commits ------- dbde648 use the clock mock for progress indicator tests
nicolas-grekas
added a commit
that referenced
this pull request
Mar 17, 2016
…s (xabbuh) This PR was merged into the 2.8 branch. Discussion ---------- [Console] use the clock mock for progress indicator tests | Q | A | ------------- | --- | Branch? | 2.8 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #18200 | License | MIT | Doc PR | Unfortunately, I opened #18200 for the wrong branch. Commits ------- 584b752 use the clock mock for progress indicator tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.