Removed 3.0.0 restriction for the Ldap component in the Security component #18201
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @csarrazi. |
nicolas-grekas
added a commit
that referenced
this pull request
Mar 16, 2016
…Security component (csarrazi) This PR was merged into the 3.0 branch. Discussion ---------- Removed 3.0.0 restriction for the Ldap component in the Security component | Q | A | ------------- | --- | Branch? | 3.0 | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | This ticket removes the restriction on version 3.0 of the Ldap component, as the component is now both backward and forward-compatible. This PR is being made against the `3.0` branch and not in the `2.8` branch as it seems that all other dependencies rely on `~2.8|~3.0.0` for the `2.8` branch. There will be a conflict with the `master` branch. The versions to use on the `master` branch is `~3.1` for both `composer.json` files, as the authentication provider and the user provider rely on the new interface, and the `LdapInterface::query()` method, instead of `LdapClientInterface::search()`, which is deprecated. Commits ------- f576c9f Removed 3.0 restriction for the Ldap component in the Security component
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ticket removes the restriction on version 3.0 of the Ldap component, as the component is now both backward and forward-compatible.
This PR is being made against the
3.0branch and not in the2.8branch as it seems that all other dependencies rely on~2.8|~3.0.0for the2.8branch.There will be a conflict with the
masterbranch. The versions to use on themasterbranch is~3.1for bothcomposer.jsonfiles, as the authentication provider and the user provider rely on the new interface, and theLdapInterface::query()method, instead ofLdapClientInterface::search(), which is deprecated.