[FrameworkBundle][2.8] Add tests for the Controller class #18206
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Missing dependency for Twig in the FrameworkBundle's |
|
@xabbuh thanks, fixed. |
|
AppVeyor error not related. |
| @@ -86,7 +86,8 @@ | |||
| "monolog/monolog": "~1.11", | |||
| "ocramius/proxy-manager": "~0.4|~1.0|~2.0", | |||
| "egulias/email-validator": "~1.2", | |||
| "phpdocumentor/reflection": "^1.0.7" | |||
| "phpdocumentor/reflection": "^1.0.7", | |||
| "twig/twig": "~1.23|~2.0" | |||
There was a problem hiding this comment.
we already have Twig as a regular requirement. Having it in both section is bad as it can create weird behaviors in Composer (unlikely here for ow as the constraint is the same, but they may likely get out of sync)
There was a problem hiding this comment.
My bad my first intent was to update the FrameworkBundle one.
There was a problem hiding this comment.
So, this change should be removed.
6a056b2 to
6af2815
Compare
|
Thank you @dunglas. |
fabpot
added a commit
that referenced
this pull request
Mar 21, 2016
…s (dunglas) This PR was squashed before being merged into the 2.8 branch (closes #18206). Discussion ---------- [FrameworkBundle][2.8] Add tests for the Controller class | Q | A | ------------- | --- | Branch? | 2.8 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a Backport tests of #18193 to the `abstract` Controller. Commits ------- 5ee9f93 [FrameworkBundle][2.8] Add tests for the Controller class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport tests of #18193 to the
abstractController.