Skip to content

[WIP] Fix #18188 #18214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

[WIP] Fix #18188 #18214

wants to merge 3 commits into from

Conversation

dunglas
Copy link
Member

@dunglas dunglas commented Mar 17, 2016

Q A
Branch? 2.8
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #18188
License MIT
Doc PR n/a

I try to add a test (and a fix) for #18188 but I'm not able to reproduce the problem.
@hason can you explain or add a commit on my PR how to reproduce?

@hason
Copy link
Contributor

hason commented Mar 17, 2016

@dunglas I prepared a test hason-contributions@5f9e177

@GuilhemN
Copy link
Contributor

I got it, the parent of the class can't be loaded so php throws a fatal error (not a \ReflectionException).
This seems to be an issue hard to fix... and maybe should be fixed in the twig bundle instead.

[DependencyInjection] Added a failing test for autowiring
@nicolas-grekas
Copy link
Member

Should be implemented using similar logic than in ReflectionCaster:
https://github.com/symfony/symfony/blob/master/src/Symfony/Component/VarDumper/Caster/ReflectionCaster.php#L218-L234

@nicolas-grekas
Copy link
Member

Closing in favor of #18600

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants