[Intl] Fix invalid numeric literal on PHP 7 #18216
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -213,24 +213,18 @@ class NumberFormatter | |||
| ); | |||
|
|
|||
| /** | |||
| * The maximum values of the integer type in 32 bit platforms. | |||
| * The maximum value of the integer type in 32 bit platforms. | |||
| * | |||
| * @var array | |||
ba228f0 to
1ea3cb1
Compare
|
While you are at it, the When merging in 3.0 the |
1ea3cb1 to
999c0a5
Compare
|
@Tobion updated |
|
👍 Status: Reviewed |
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Mar 18, 2016
This PR was merged into the 2.3 branch. Discussion ---------- [Intl] Fix invalid numeric literal on PHP 7 | Q | A | ------------- | --- | Branch? | 2.3 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Work around `true === is_float(-9223372036854775808)`. Commits ------- 999c0a5 [NumberFormatter] Fix invalid numeric literal on PHP 7
This was referenced Mar 25, 2016
Merged
Closed
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work around
true === is_float(-9223372036854775808).