[ClassLoader] Improve exception messages of the debug class loader #1825
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -55,7 +55,13 @@ class DebugUniversalClassLoader extends UniversalClassLoader | |||
| require $file; | |||
|
|
|||
| if (!class_exists($class, false) && !interface_exists($class, false)) { | |||
| throw new \RuntimeException(sprintf('The autoloader expected class "%s" to be defined in file "%s". You probably have a typo in the namespace or the class name.', $class, $file)); | |||
| if (!file_exists($file)) { | |||
There was a problem hiding this comment.
The file always exist at this point.
|
Ok, I updated this to just clarify the message, because when I got the issue after some serious copy-paste coding, I thought it was quite confusing - it seems to imply you mistyped the class name when using the class, and therefore it was not found, while the typo is in the class's file itself. |
fabpot
added a commit
that referenced
this pull request
Aug 2, 2011
Commits ------- c0571fc [ClassLoader] Improve exception messages of the debug class loader Discussion ---------- [ClassLoader] Improve exception messages of the debug class loader --------------------------------------------------------------------------- by Seldaek at 2011/07/31 14:01:40 -0700 Ok, I updated this to just clarify the message, because when I got the issue after some serious copy-paste coding, I thought it was quite confusing - it seems to imply you mistyped the class name when using the class, and therefore it was not found, while the typo is in the class's file itself.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.