[FileSystem] Google app engine filesystem #18271
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mtricht
commented
Mar 23, 2016
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #17922 |
| License | MIT |
| Doc PR | - |
| @@ -486,13 +486,13 @@ public function tempnam($dir, $prefix) | |||
| { | |||
| list($scheme, $hierarchy) = $this->getSchemeAndHierarchy($dir); | |||
|
|
|||
| // If no scheme or scheme is "file" create temp file in local filesystem | |||
| if (null === $scheme || 'file' === $scheme) { | |||
| // If no scheme or scheme is "file" or "gs" create temp file in local filesystem | |||
There was a problem hiding this comment.
If others agree, we could add a brief help message explaining what gs is. Instead of this:
// If no scheme or scheme is "file" or "gs" create temp file in local filesystem
Something like this:
// If no scheme or scheme is "file" or "gs" (Google Cloud) create temp file in local filesystem
|
👍 with a comment as suggested by @javiereguiluz |
|
Thank you @swordbeta. |
fabpot
added a commit
that referenced
this pull request
Mar 27, 2016
This PR was submitted for the master branch but it was merged into the 2.8 branch instead (closes #18271). Discussion ---------- [FileSystem] Google app engine filesystem | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #17922 | License | MIT | Doc PR | - Commits ------- 06d8697 [FileSystem] Add support for Google App Engine.
This was referenced Mar 27, 2016
Closed
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.