[Form] remove useless copy in ChoiceType #18316
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`ChoiceListFactoryInterface` expected `$group_by` to be a callable or null not an array. The factory defaults `group_by` to `ChoiceListInterface::getStructuredValues`.
|
Note to the merger: sorry for the conflict in 3.0 :/ |
|
👍 Good catch. This piece of code does not seem to have any effect as a Status: Reviewed |
|
@Tobion thanks for the review :) The effect I'm interested in is a comparison with backfire profiling! |
|
This is due to this. |
|
Thank you @HeahDude. |
fabpot
added a commit
that referenced
this pull request
Mar 30, 2016
This PR was merged into the 2.7 branch. Discussion ---------- [Form] remove useless copy in ChoiceType | Q | A | ------------- | --- | Branch? | 2.7+ | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | symfony/symfony-docs#6393 `ChoiceListFactoryInterface` expected `$groupBy` to be a callable or null, not an array ([ref](https://github.com/symfony/symfony/blob/2.7/src/Symfony/Component/Form/ChoiceList/Factory/ChoiceListFactoryInterface.php#L111)). The factory defaults `groupBy` to `ChoiceListInterface::getStructuredValues()` ([ref](https://github.com/symfony/symfony/blob/2.7/src/Symfony/Component/Form/ChoiceList/Factory/DefaultChoiceListFactory.php#L122)). Hence, the copy of the choices array and the recursive flip are useless and may be slowing down performances imho (especially with `EntityType`). Commits ------- 562f5e4 [Form] remove useless code in ChoiceType
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ChoiceListFactoryInterfaceexpected$groupByto be a callable or null, not an array (ref).The factory defaults
groupBytoChoiceListInterface::getStructuredValues()(ref).Hence, the copy of the choices array and the recursive flip are useless and may be slowing down performances imho (especially with
EntityType).