Skip to content

[FrameworkBundle][TwigBridge] fix high deps tests #18354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 30, 2016
Merged

[FrameworkBundle][TwigBridge] fix high deps tests #18354

merged 1 commit into from
Mar 30, 2016

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Mar 29, 2016

Q A
Branch? 2.7
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR

@xabbuh xabbuh force-pushed the twig-bridge-deps-high branch from b3e808f to b249dca Compare March 29, 2016 20:38
@xabbuh xabbuh added the Ready label Mar 29, 2016
@xabbuh
Copy link
Member Author

xabbuh commented Mar 29, 2016

The test suite is green again.

@xabbuh xabbuh changed the title [TwigBridge] fix high deps tests [FrameworkBundle][TwigBridge] fix high deps tests Mar 29, 2016
@xabbuh xabbuh force-pushed the twig-bridge-deps-high branch from b249dca to aa4dd4f Compare March 29, 2016 20:47
@nicolas-grekas
Copy link
Member

👍

@stof
Copy link
Member

stof commented Mar 30, 2016

👍

@fabpot
Copy link
Member

fabpot commented Mar 30, 2016

Thank you @xabbuh.

@fabpot fabpot merged commit aa4dd4f into symfony:2.7 Mar 30, 2016
fabpot added a commit that referenced this pull request Mar 30, 2016
@fabpot
bug #18354 [FrameworkBundle][TwigBridge] fix high deps tests (xabbuh)
45755e0 
This PR was merged into the 2.7 branch.

Discussion
----------

[FrameworkBundle][TwigBridge] fix high deps tests

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

Commits
-------

aa4dd4f fix high deps tests
@xabbuh xabbuh deleted the twig-bridge-deps-high branch March 30, 2016 10:01
@fabpot fabpot mentioned this pull request Mar 30, 2016
Merged
This was referenced Apr 29, 2016
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug FrameworkBundle Ready Status: Needs Review TwigBridge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@xabbuh @nicolas-grekas @stof @fabpot @javiereguiluz @carsonbot