[Security] Fixed SwitchUserListener when exiting an impersonation with AnonymousToken #18425
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -162,7 +163,7 @@ private function attemptExitUser(Request $request) | |||
| throw new AuthenticationCredentialsNotFoundException('Could not find original Token object.'); | |||
| } | |||
|
|
|||
| if (null !== $this->dispatcher) { | |||
| if (null !== $this->dispatcher && !$original instanceof AnonymousToken) { | |||
There was a problem hiding this comment.
I think it would be better to check if $original->getUser is an instance of the UserInterface to also support custom tokens that might return something else.
There was a problem hiding this comment.
you are right. I updated the code and added some tests.
|
👍 |
| @@ -149,6 +149,54 @@ public function testExitUserDispatchesEventWithRefreshedUser() | |||
| $listener->handle($this->event); | |||
| } | |||
|
|
|||
| public function testExitUserDontDispatchesEventWithStringUser() | |||
There was a problem hiding this comment.
testExitUserDoesNotDispatchEventWithStringUser
|
@lyrixx are you really allowing anonymous users to impersonate users ? This looks weird. But the fix is indeed valid |
|
@stof Yes I do that. It's an awesome idea for demo app (you may see it on thursday). |
…ith AnonymousToken If you configure a firewall with switch user with `role: IS_AUTHENTICATED_ANONYMOUSLY` it's impossible to exit the impersonation because the next line `$this->provider->refreshUser($original->getUser())` will fail. It fails because `RefreshUser` expects an instance of `UserInterface` and here it's a string. Therefore, it does not make sense to refresh an Anonymous Token, right ?
|
Thank you @lyrixx. |
fabpot
added a commit
that referenced
this pull request
Apr 5, 2016
…onation with AnonymousToken (lyrixx) This PR was merged into the 2.3 branch. Discussion ---------- [Security] Fixed SwitchUserListener when exiting an impersonation with AnonymousToken | Q | A | ------------- | --- | Branch? | 2.3 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - If you configure a firewall with switch user with `role: IS_AUTHENTICATED_ANONYMOUSLY` it's impossible to exit the impersonation because the next line `$this->provider->refreshUser($original->getUser())` will fail. It fails because `RefreshUser` expects an instance of `UserInterface` and here it's a string. Therefore, it does not make sense to refresh an Anonymous Token, right ? Commits ------- 59fea72 [Security] Fixed SwitchUserListener when exiting an impersonication with AnonymousToken
This was referenced Apr 29, 2016
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you configure a firewall with switch user with
role: IS_AUTHENTICATED_ANONYMOUSLYit's impossible to exit theimpersonation because the next line
$this->provider->refreshUser($original->getUser())will fail. It fails becauseRefreshUserexpects an instance of
UserInterfaceand here it's a string.Therefore, it does not make sense to refresh an Anonymous Token, right ?