[Logging] Add support for Firefox (43+) in ChromePhpHandler #18439
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
👍 Status: Reviewed In the long term we should probably rather make this information somehow accessible in the base handler to not need to duplicate it (see Seldaek/monolog#761). |
|
Thank you @arjenm. |
nicolas-grekas
added a commit
that referenced
this pull request
Apr 5, 2016
…r (arjenm) This PR was merged into the 2.3 branch. Discussion ---------- [Logging] Add support for Firefox (43+) in ChromePhpHandler | Q | A | ------------- | --- | Branch? | 2.3 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | none | License | MIT | Doc PR | none Firefox added support for Chrome Logger a while back in [version 43](https://www.mozilla.org/en-US/firefox/43.0/releasenotes/). Support for Firefox was added in the ChromePHPHandler of [Monolog 1.18.0](Seldaek/monolog#721), although its not mentioned in the changelog. This PR is basically just to replace the originally copied regular expression, [with this new one](Seldaek/monolog@fa96f6a). There should be no BC breakage, even though users may be using Monolog versions between 1.11 and 1.18. Monolog's ChromePHPHandler only got minor touch ups and its protocol (and thus output) remained the same. This fix in fact also adds support for Firefox 43+ to older Monolog's when using the Symfony-version of that handler (which they should be using), since the Symfony-version of ChromePhpHandler completely overwrites the 'headersAccepted'-check of Monolog. Commits ------- c8efc4d [Logging] Add support for firefox in ChromePhpHandler
This was referenced Apr 29, 2016
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Firefox added support for Chrome Logger a while back in version 43.
Support for Firefox was added in the ChromePHPHandler of Monolog 1.18.0, although its not mentioned in the changelog.
This PR is basically just to replace the originally copied regular expression, with this new one.
There should be no BC breakage, even though users may be using Monolog versions between 1.11 and 1.18. Monolog's ChromePHPHandler only got minor touch ups and its protocol (and thus output) remained the same.
This fix in fact also adds support for Firefox 43+ to older Monolog's when using the Symfony-version of that handler (which they should be using), since the Symfony-version of ChromePhpHandler completely overwrites the 'headersAccepted'-check of Monolog.