[Form] Reverted string expectation in ChoiceToValueTransformer #18462
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walczakmac
commented
Apr 6, 2016
| Q | A |
|---|---|
| Branch? | 3.0 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #18461 |
| License | MIT |
| Doc PR | n/a |
| @@ -78,10 +78,8 @@ public function testReverseTransform($in, $out, $inWithNull, $outWithNull) | |||
| public function reverseTransformExpectsStringOrNullProvider() | |||
There was a problem hiding this comment.
You also need to rename those functions with *ExpectsScalarOrNull*.
|
See also #17760 (comment) for a reason to not revert that change. |
|
Another reason would be consistency with the $builder->add('emailNotificationsEnabled', ChoiceType::class, [
'required' => false,
'multiple' => false,
'choices' => [0, 1],
'empty_data' => 1, // works If we revert by merging this PR
]);
$builder->add('emailNotificationsEnabled', ChoiceType::class, [
'required' => false,
'multiple' => true, // ChoicesToValuesTransformer will be called
'choices' => [0, 1],
'empty_data' => array(1), // won't work it expects array of strings array('1')
]); |
|
And |
|
Also consider that: $builder->add('emailNotificationsEnabled', ChoiceType::class, [
'required' => false,
'multiple' => false,
'choices' => [null, 0, 1],
'empty_data' => 1, // will match 0, needs the key '2' to match 1
]); |
|
Note that if accepted, this PR should be merged in 2.7. |
|
Now I see that there are too many cons when reverting it to previous state, and it will be much easier if I use strings there instead of integers. I'll just close the PR and the ticket, also thanks for your help @HeahDude. |
|
No worry ;) Thank you for the report. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.