[DomCrawler] No more exception on field name with strange format #18570
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests are failing, but if this PR can be accepted I will need some help to manage all the tests about malformed name... |
| } | ||
| } | ||
|
|
||
| return $segments; | ||
| } | ||
|
|
||
| throw new \InvalidArgumentException(sprintf('Malformed field path "%s"', $name)); | ||
| return [$name]; |
|
this cannot be accepted without tests covering these cases to prevent regressions |
|
I think that the things I will do is to remove the tests that check if the DomCrawler raise error when the name is malformed. |
|
@guiled remove these tests & move the used-to-be invalid names to a test ensuring they now are accepted :) |
|
@guiled do you have time to finish this PR? |
|
I'm taking over to finish this one. See #19138 |
fabpot
added a commit
that referenced
this pull request
Jun 22, 2016
…format (guiled, fabpot) This PR was merged into the 2.7 branch. Discussion ---------- [DomCrawler] No more exception on field name with strange format | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #18569, #18570 | License | MIT | Doc PR | n/a Commits ------- e204913 finished previous commit 953a383 No more exception for malformed input name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.