[DependencyInjection] top-level anonymous services must be public #18709
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
xabbuh
commented
May 4, 2016
| Q | A |
|---|---|
| Branch? | 2.3 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #18703 |
| License | MIT |
| Doc PR |
|
👍, a test case would be great |
|
The file loader Test case I had to change covers this. |
|
Thank you @xabbuh. |
nicolas-grekas
added a commit
that referenced
this pull request
May 6, 2016
… public (xabbuh) This PR was merged into the 2.3 branch. Discussion ---------- [DependencyInjection] top-level anonymous services must be public | Q | A | ------------- | --- | Branch? | 2.3 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #18703 | License | MIT | Doc PR | Commits ------- 13a47c3 top-level anonymous services must be public
|
@nicolas-grekas By the way, in the same test we ensure that anonymous services used in definition arguments are still private. |
|
Yep, I checked that also before merging :) |
This was referenced May 9, 2016
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.