Catch \Throwable #18812
Closed
Catch \Throwable #18812
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
| @@ -77,6 +77,9 @@ public function load($resource, $type = null) | |||
| } catch (\Exception $e) { | |||
| $this->loading = false; | |||
| throw $e; | |||
| } catch (\Throwable $e) { | |||
| $this->loading = false; | |||
| throw $e; | |||
There was a problem hiding this comment.
in php7 isn't possible implements \Throwable interface only extends \Exception class, so why not use only one catch with \Throwable?
There was a problem hiding this comment.
because we support PHP5 also
fabpot
added a commit
that referenced
this pull request
May 23, 2016
This PR was merged into the 2.7 branch. Discussion ---------- Catch \Throwable | Q | A | ------------- | --- | Branch? | 2.7, 2.8, 3.0 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | Yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a Related #18765, #15949 Depends on #18812 Commits ------- 103526b Catch \Throwable
fabpot
added a commit
that referenced
this pull request
May 23, 2016
This PR was merged into the 2.8 branch. Discussion ---------- Catch \Throwable | Q | A | ------------- | --- | Branch? | 2.8, 3.0 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | Mostly! | Fixed tickets | n/a | License | MIT | Doc PR | n/a The first commit is based on #15949 Depends on #18813, #18812 ---- I'm new to symfony, so I'm not sure where are all the places where it makes sense to actually catch the throwable and where not. I added most places that seemed logical and when I wasn't sure, I added it anyway. I'm hoping you guys (and girls?) can point out the places where the catch should not be added, I'll fix it and then I can create several PR's for the older branches. A lot of this IMHO should go also to 3.0. Commits ------- de671f4 Catch \Throwable
symfony-splitter
pushed a commit
to symfony/dependency-injection
that referenced
this pull request
May 23, 2016
This PR was merged into the 2.8 branch. Discussion ---------- Catch \Throwable | Q | A | ------------- | --- | Branch? | 2.8, 3.0 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | Mostly! | Fixed tickets | n/a | License | MIT | Doc PR | n/a The first commit is based on symfony/symfony#15949 Depends on symfony/symfony#18813, symfony/symfony#18812 ---- I'm new to symfony, so I'm not sure where are all the places where it makes sense to actually catch the throwable and where not. I added most places that seemed logical and when I wasn't sure, I added it anyway. I'm hoping you guys (and girls?) can point out the places where the catch should not be added, I'll fix it and then I can create several PR's for the older branches. A lot of this IMHO should go also to 3.0. Commits ------- de671f4 Catch \Throwable
|
Thank you @fprochazka. |
nicolas-grekas
added a commit
that referenced
this pull request
May 30, 2016
This PR was squashed before being merged into the 2.3 branch (closes #18812). Discussion ---------- Catch \Throwable | Q | A | ------------- | --- | Branch? | 2.3, 2.7, 2.8, 3.0 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | Yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a Related #18765, #15949 Commits ------- 893cf00 Catch \Throwable
Merged
This was referenced Jun 6, 2016
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #18765, #15949