[Cache] Add PhpArrayAdapter to use shared memory on PHP 7.0 #18823
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| if ('N;' === $value) { | ||
| $value = null; | ||
| } elseif (isset($value[2]) && is_string($value) && ':' === $value[1]) { |
There was a problem hiding this comment.
is_string should come before isset($value[2]) IMO
1f8c746 to
d9328e2
Compare
| } | ||
| } | ||
|
|
||
| $dump = <<<EOF |
There was a problem hiding this comment.
This should be enclosed with nowdoc instead of heredoc.
| */ | ||
| class NullAdapter implements AdapterInterface | ||
| { | ||
| private $createCacheItem; |
928dc61 to
c6e08fc
Compare
|
I did the changes |
| EOF; | ||
|
|
||
| foreach ($values as $key => $value) { | ||
| CacheItem::validateKey($key); |
There was a problem hiding this comment.
because PHP casts numeric string keys to ints, we should cast ints to string here:
`is_int($key) ? (string) $key : $key);
| $fallbackKeys = array(); | ||
|
|
||
| foreach ($keys as $key) { | ||
| if (!is_string($key)) { |
There was a problem hiding this comment.
this check should be done before calling generateItems
There was a problem hiding this comment.
indeed. Doing it in the generator will throw the exception too late (the iterator will throw it during iteration, while it must be throw by getItems)
|
I suggest renaming this adapter to Php7Adapter (ans use the OpcacheAdapter name in #18894) |
|
I did some benchmarks to check the PHP 5.6 support in this PR. I used three Docker containers with only PHP/HHVM installed, on the same host. I used Apache Benchmark with 1000 requests at a concurrency of 100 ( The results are the following:
This seems to indicate that having an array filled with data in PHP 5.6 is significantly slower than having an empty array. Therefore, I removed the PHP 5.6 support for this PhpArrayAdapter in the |
4db11cd to
198e04c
Compare
|
👍 |
bb8e068 to
c507cc0
Compare
|
👍 |
| try { | ||
| $value = serialize($value); | ||
| } catch (\Exception $e) { | ||
| throw new InvalidArgumentException(sprintf('Cache key "%s has non-serializable %s value', $key, get_class($value)), 0, $e); |
c507cc0 to
4ecde9d
Compare
|
I did the changes. |
| private $fallbackPool; | ||
|
|
||
| /** | ||
| * @param string $file The PHP file were values are cached. |
4ecde9d to
28a40d2
Compare
|
I did the change |
|
Thank you @tgalopin. |
fabpot
added a commit
that referenced
this pull request
Jun 28, 2016
…P 7.0 (tgalopin) This PR was merged into the 3.2-dev branch. Discussion ---------- [Cache] Add PhpArrayAdapter to use shared memory on PHP 7.0 | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | WIP | Fixed tickets | - | License | MIT | Doc PR | - Depends on #18825 This PR aims to implement a Symfony Cache adapter able to build files optimized for OPCache memory storage. Any kind of static data that can be warmed up is a candidate for OPcache storage. This PR is limited to the implementation of the Adapter. It's usage in the annotations caching system is implemented in the PR #18533. The aim is also to use this adapter in other contexts (validator, serializer, ...). Commits ------- 28a40d2 [Cache] Add PhpArrayAdapter to use shared memory on PHP 7.0+
fabpot
added a commit
that referenced
this pull request
Jul 30, 2016
…e warmer for annotations (tgalopin) This PR was squashed before being merged into the 3.2-dev branch (closes #18533). Discussion ---------- [FrameworkBundle] Wire PhpArrayAdapter with a new cache warmer for annotations | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | WIP | Fixed tickets | - | License | MIT | Doc PR | - Depends on #18825 and #18823 This PR implements the usage of the new OpCacheAdapter in the annotations caching system. The idea to use this adapter as much as possible in Symfony (validator, serializer, ...). These other implementations will be the object of different PRs. Commits ------- f950a2b [FrameworkBundle] Wire PhpArrayAdapter with a new cache warmer for annotations
symfony-splitter
pushed a commit
to symfony/cache
that referenced
this pull request
Jul 30, 2016
…e warmer for annotations (tgalopin) This PR was squashed before being merged into the 3.2-dev branch (closes #18533). Discussion ---------- [FrameworkBundle] Wire PhpArrayAdapter with a new cache warmer for annotations | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | WIP | Fixed tickets | - | License | MIT | Doc PR | - Depends on symfony/symfony#18825 and symfony/symfony#18823 This PR implements the usage of the new OpCacheAdapter in the annotations caching system. The idea to use this adapter as much as possible in Symfony (validator, serializer, ...). These other implementations will be the object of different PRs. Commits ------- f950a2b [FrameworkBundle] Wire PhpArrayAdapter with a new cache warmer for annotations
symfony-splitter
pushed a commit
to symfony/http-kernel
that referenced
this pull request
Jul 30, 2016
…e warmer for annotations (tgalopin) This PR was squashed before being merged into the 3.2-dev branch (closes #18533). Discussion ---------- [FrameworkBundle] Wire PhpArrayAdapter with a new cache warmer for annotations | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | WIP | Fixed tickets | - | License | MIT | Doc PR | - Depends on symfony/symfony#18825 and symfony/symfony#18823 This PR implements the usage of the new OpCacheAdapter in the annotations caching system. The idea to use this adapter as much as possible in Symfony (validator, serializer, ...). These other implementations will be the object of different PRs. Commits ------- f950a2b [FrameworkBundle] Wire PhpArrayAdapter with a new cache warmer for annotations
symfony-splitter
pushed a commit
to symfony/framework-bundle
that referenced
this pull request
Jul 30, 2016
…e warmer for annotations (tgalopin) This PR was squashed before being merged into the 3.2-dev branch (closes #18533). Discussion ---------- [FrameworkBundle] Wire PhpArrayAdapter with a new cache warmer for annotations | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | WIP | Fixed tickets | - | License | MIT | Doc PR | - Depends on symfony/symfony#18825 and symfony/symfony#18823 This PR implements the usage of the new OpCacheAdapter in the annotations caching system. The idea to use this adapter as much as possible in Symfony (validator, serializer, ...). These other implementations will be the object of different PRs. Commits ------- f950a2b [FrameworkBundle] Wire PhpArrayAdapter with a new cache warmer for annotations
Merged
weaverryan
added a commit
to symfony/symfony-docs
that referenced
this pull request
Jan 28, 2017
…weaverryan) This PR was merged into the 3.2 branch. Discussion ---------- Covering two missing Cache adapters introduced in 3.2 Hi guys! These are 2 missing adapters that were introduced in 3.2! symfony/symfony#18894 and symfony/symfony#18823 Cheers! Commits ------- a3e69e2 Tweaks based on feedback! 1b6cb69 Covering two missing adapters introduced in 3.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #18825
This PR aims to implement a Symfony Cache adapter able to build files optimized for OPCache memory storage. Any kind of static data that can be warmed up is a candidate for OPcache storage.
This PR is limited to the implementation of the Adapter. It's usage in the annotations caching system is implemented in the PR #18533. The aim is also to use this adapter in other contexts (validator, serializer, ...).